added InvokeMethod on WmiClass #99
Conversation
pkg/wmiinstance/WmiClass.go
Outdated
| @@ -285,6 +285,16 @@ func (c *WmiClass) InvokeMethod(methodName string, methodParams []string, inputO | |||
| // both are SWbemObjects: https://docs.microsoft.com/en-us/windows/win32/wmisdk/swbemobject | |||
| } | |||
|
|
|||
| func (c *WmiClass) InvokeMethodWithLiteralParams(methodName string, params ...interface{}) ([]interface{}, error) { | |||
There was a problem hiding this comment.
Where are we planning to use this?
There was a problem hiding this comment.
We use it to create cluster group sets, before we didn't have a way to invoke static methods on wmi classes.
There was a problem hiding this comment.
Also, how different is this from the unimplemented InvokeMethod call that is right above? (line 282)
There was a problem hiding this comment.
In other words, let's just name this function "InvokeMethod"
There was a problem hiding this comment.
the method above takes a methodParams []string argument, this definition takes effectively an array of interfaces.
(one of the params on the call we invoke this is actually a string[] itself.
There was a problem hiding this comment.
I hesitated to replace the signature as technically the original InvokeMethod is a public interface (residing in a pkg subdir with capital name). But can just replace if you think there is no build dependency anywhere on it (obviously there is no functional dependency as it is not implemented)
There was a problem hiding this comment.
replaced call, please resolve this comment if you are satisfied @JocelynBerrendonner
There was a problem hiding this comment.
Thanks! Looks good.
jocardeMSFT
changed the title
Adding ability to call static methods on Wmi Classes using literal parameters in line with pattern of Wmi Instances