Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MgCommandMetadata.json #2979

Closed
wants to merge 1 commit into from

Conversation

lukasgd1913
Copy link

Added permissionreference for "/identity/conditionalAccess" entries.



Fixes #

Changes proposed in this pull request

Other links

Added permissionreference for "/identity/conditionalAccess" entries.
@lukasgd1913 lukasgd1913 requested a review from a team as a code owner October 1, 2024 10:09
@timayabi2020
Copy link
Contributor

Hi @lukasgd1913 thank you for making this contribution. Kindly note that MgCommandMetadata.json is autogenerated during cmdlet build. You can open the issue here https://github.com/microsoftgraph/msgraph-sdk-powershell/issues so that the team responsible can be tagged and respond to it.

@lukasgd1913
Copy link
Author

thanks for the message @timayabi2020
I am aware that this is autogenerated. This was already in the description of the pull request. But it also said that you look at the pull request and adjust it in the automation.

@timayabi2020
Copy link
Contributor

timayabi2020 commented Oct 3, 2024

@lukasgd1913 for every WeeklyDocsRefresh PR which is responsible for updating the Open Api files used for generating/updating cmdlets, the MgCommandMetadata.json file is also updated with metadata for generated cmdlets. This means that even if we check in your changes they will still be overwritten in the next automated run. My suggestion is that we should try and solve the issue you are addressing in a different way, other than directly modifying the metadata file. i.e. Find out why we have missing permission references for some paths.

Also, if you look at the PRs responsible for updating metadata file (See sample PR here), the message is that we should check for unnecessary deletions and additions and not go ahead to directly modify anything on the generated files. This is supposed to prompt the reviewer to check on the process responsible for making the changes.

@lukasgd1913 lukasgd1913 closed this Oct 4, 2024
@lukasgd1913 lukasgd1913 deleted the patch-1 branch October 4, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants