Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -CountVariable parameter #352

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Add -CountVariable parameter #352

merged 1 commit into from
Aug 31, 2020

Conversation

peombwa
Copy link
Member

@peombwa peombwa commented Aug 27, 2020

This PR closes #152 by proposing the following changes:

  • Ensures all $count=true is always in lowercase. MS Graph doesn't support Camel cased count values.
  • Adds a runtime -CountVariable parameter to all cmdlets that return a collection. This will be used by customers to get back a deserialized value of @odata.count returned in the response body. By default, this variable will be stored in the global scope.
  • Adds -CV alias for -CountVariable.
  • Makes -Count parameter private i.e. it won't be exposed to customers.
  • Ensures $count=true is always set with -CountVariable is present.

Proposed use

image

@peombwa peombwa self-assigned this Aug 27, 2020
@georgend
Copy link
Contributor

@peombwa Ready to Merge?

@georgend georgend merged commit fe25a05 into dev Aug 31, 2020
@peombwa peombwa deleted the po/countSupport branch September 8, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better support for -count parameter
2 participants