Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Improvements #380

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Profile Improvements #380

merged 4 commits into from
Sep 17, 2020

Conversation

peombwa
Copy link
Member

@peombwa peombwa commented Sep 17, 2020

This PR makes the improvements to profiles support:

  1. Due to AutoREST validation, our OpenAPI docs cannot have beta version in the info object. To avoid this, we use v1.0-beta which gets leaked out customers when selecting profiles. This PR fixes this by masking v1.0-beta profile name with beta. Closes v1.0-beta profile should be renamed to beta. #377 .
  2. Default modules to use v1.0 profile. Customers can opt-in to beta by calling Select-MgProfile -Name beta. Closes Default to V1.0 profile #376 .
  3. Rename all Azure Profile messages in generated modules to Microsoft Graph Profile to avoid API confusion.

Changes in action

image

In this case, Microsoft.Graph.Search is a beta only module. When we import it with a default profile of v1.0, we are presented with a warning message informing us that this module is not available in v1.0. If we select beta profile, the SDK reloads the imported module with all the cmdlets that call beta endpoint.

@peombwa peombwa self-assigned this Sep 17, 2020
@peombwa peombwa merged commit 3d31022 into dev Sep 17, 2020
@peombwa peombwa deleted the po/profileImpovements branch September 17, 2020 23:13
@georgend georgend added this to the 1.0 GA milestone Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.0-beta profile should be renamed to beta. Default to V1.0 profile
4 participants