Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Module Response Count #542

Merged
merged 4 commits into from
Feb 10, 2021
Merged

Service Module Response Count #542

merged 4 commits into from
Feb 10, 2021

Conversation

peombwa
Copy link
Member

@peombwa peombwa commented Feb 3, 2021

This PR closes #418 by removing Count, Keys, and Values properties from IAssociativeArray and their implementations in model classes.

IAssociativeArray is implemented by model classes that have an additionalProperties and is a subset of IDictionary that doesn't implement IEnumerable or IDictionary. Its implementation of Count, which counts the number of items in additionalProperties, was blocking PowerShell's count thus resulting in a wrong count when filtering of getting a single item.

Before

image

After

image

@peombwa peombwa added this to the 1.4.0 milestone Feb 3, 2021
@peombwa peombwa self-assigned this Feb 3, 2021
@peombwa peombwa merged commit 1664d81 into dev Feb 10, 2021
@peombwa peombwa deleted the bugfixes/ServiceModuleCount branch February 10, 2021 23:14
@peombwa peombwa mentioned this pull request Feb 19, 2021
This was referenced Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several cmdlets don't report the right count when 1 owner/member
2 participants