Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow post requests without content-type header #109

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Allow post requests without content-type header #109

merged 1 commit into from
Jan 17, 2022

Conversation

samwelkanda
Copy link
Contributor

Overview

Fixes an issue where PUT/PATCH/POST requests will fail on retry if there is no content-type header supplied in the request. requests library will only set the Content-Type if you use data, files or json as arguments

Demo

N/A

Notes

N/A

Testing Instructions

N/A

closes #108

@samwelkanda samwelkanda self-assigned this Jan 17, 2022
@samwelkanda samwelkanda merged commit 0c1fc5e into dev Jan 17, 2022
@samwelkanda samwelkanda deleted the bug/no-contentype-header branch January 17, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebkiage calebkiage calebkiage approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@jobala jobala Awaiting requested review from jobala

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@shemogumbe shemogumbe Awaiting requested review from shemogumbe

Assignees

@samwelkanda samwelkanda

Labels
bug: client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header check failing
2 participants
@samwelkanda @calebkiage