Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod dependencies #1236

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Update go.mod dependencies #1236

merged 1 commit into from
Mar 4, 2021

Conversation

tmthrgd
Copy link
Collaborator

@tmthrgd tmthrgd commented Mar 4, 2021

There have been a number of hard to understand fuzzing errors recently including NULL derefences in pthread_create called from runtime.newm and "fatal error: unknown caller pc" errors from various places. There are no unsafe imports in miekg/dns, so it's possible memory corruption or register clobbering is occurring in one of our dependencies.

Try bumping the go.mod versions to latest and see if that settles things down.

I don't think we'd end up importing the packages at all, but it could be related to golang/go#44269 or something similar. Or perhaps some incorrect syscall definition in x/sys.

@tmthrgd tmthrgd requested a review from miekg March 4, 2021 03:54
@miekg
Copy link
Owner

miekg commented Mar 4, 2021 via email

cbot[bot]
cbot bot approved these changes Mar 4, 2021
Copy link

@cbot cbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by miekg

@cbot cbot bot merged commit b694ab3 into miekg:master Mar 4, 2021
@tmthrgd tmthrgd deleted the go-mod-update branch March 4, 2021 07:07
aanm pushed a commit to cilium/dns that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants