Fixed connections not leaving their rooms with namespace.disconnect() #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Thanks for going all the way and coming up with the fix. I think your fix can go in as is, I'll test it a little bit before doing the merge, but it looks pretty good to me. |
|
👍 |
|
This is going to be superseeded by the implementation in version 1.0, which is almost a complete rewrite. |
|
This should be fixed in the 1.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenericNamespacedoesn't have its own disconnect, thus it caused connections from not leaving their rooms uponrequest.namespace.disconnect().I faced this issue with my app, and the associated commit fixed it. Please point out if any errors on my part.