Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write package.yaml instead of hindent.cabal #647

Merged
merged 4 commits into from
Dec 28, 2022

Conversation

toku-sa-n
Copy link
Collaborator

The main advantage is that we don't have to list all modules manually.

@toku-sa-n toku-sa-n marked this pull request as ready for review December 28, 2022 03:16
@toku-sa-n toku-sa-n marked this pull request as draft December 28, 2022 03:16
@mihaimaruseac
Copy link
Owner

We'll need to always generate the cabal file each time package.yaml changes. But otherwise, the idea of this lgtm

@toku-sa-n toku-sa-n marked this pull request as ready for review December 28, 2022 03:30
@toku-sa-n
Copy link
Collaborator Author

I thought running stack build generates the cabal file If necessary, but when I ran it after modifying HIndent's version to 5.3.6 in package.yaml, the cabal file was not changed. Maybe we need to ensure the cabal file is up-to-date on CI?

@mihaimaruseac
Copy link
Owner

Yes, I'm thinking the same

Copy link
Owner

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the files in tests? They don't look like doing much, so maybe yes?

@toku-sa-n
Copy link
Collaborator Author

Yes, these files do nothing. Do you prefer another PR for the deletion?

@mihaimaruseac
Copy link
Owner

It's ok here, just wanted to make sure.

@mihaimaruseac mihaimaruseac merged commit a30e6d0 into mihaimaruseac:master Dec 28, 2022
@toku-sa-n toku-sa-n deleted the hpack branch December 28, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants