Break a long type application (not TypeApplications)
#664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although it was reported as a type synonym issue, it was a general problem with types being written, not limited to type synonyms. This commit involves a considerable change. While we were able to keep each line within 80 lines, honestly, I feel that some parts lost readability (especially the multi-line headers in the instance declarations). Fixes: mihaimaruseac#534
mihaimaruseac
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it was reported as a type synonym issue, it was a general
problem with types being written, not limited to type synonyms.
This commit involves a considerable change.
While we were able to keepeach line within 80 lines, honestly, I feel that some parts lost
readability (especially the multi-line headers in the instance
declarations).
On second thought, it was already difficult to read before this change because these types were long, to begin with. Now that they are broken up into multiple lines, I feel that it is somewhat easier to read.
Fixes: #534