Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WarningCollection #886

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

toku-sa-n
Copy link
Collaborator

Description of the PR

#819

Checklist

@toku-sa-n toku-sa-n marked this pull request as ready for review May 4, 2024 09:10
@mihaimaruseac
Copy link
Owner

mihaimaruseac commented May 4, 2024

I think this will need special handling for different GHC versions.

The alternative, is we drop support for some older GHC.

@toku-sa-n
Copy link
Collaborator Author

toku-sa-n commented May 4, 2024

Oops, overlooked the errors. Will fix them. For the failing builds on macOS, the problem is already reported: haskell-actions/setup#77.

@toku-sa-n toku-sa-n marked this pull request as ready for review May 4, 2024 22:34
Copy link
Owner

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mihaimaruseac mihaimaruseac merged commit 3c9358e into mihaimaruseac:master May 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants