feat: Add output to file option #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callado4
reviewed
Dec 1, 2022
mike-engel
reviewed
Jan 4, 2023
I didn't try it yet, but I can certainly take a look. I don't normally code in |
|
@lewandom thanks, that would be awesome 😄 |
|
@mike-engel test added, please review. |
lewandom
requested review from
mike-engel and
callado4
and removed request for
mike-engel and
callado4
mike-engel
reviewed
Jan 18, 2023
tests/main_test.rs
Outdated
| @@ -1,14 +1,18 @@ | |||
| extern crate tempdir; | |||
There was a problem hiding this comment.
is there a reason this is still using the old edition imports?
Suggested change
| extern crate tempdir; | |
| use tempdir; |
- moved tempdir to dev dependencies - removed old style import - refactored exit code logic into main - covered print_decoded_token in tests
|
@mike-engel round 4:
|
mike-engel
reviewed
Jan 18, 2023
src/translators/encode.rs
Outdated
| if atty::is(Stream::Stdout) { | ||
| println!("{}", jwt); | ||
| } else { | ||
| print!("{}", jwt); | ||
| } | ||
| }; | ||
| exit(0); |
There was a problem hiding this comment.
Should this exit be removed now as well?
|
Done :) |
mike-engel
approved these changes
Jan 19, 2023
|
Very sorry for the delay, but this is in 6.0.0 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #217.
Preflight checklist