Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [fanbox] fix list indices error #5951

Closed
wants to merge 2 commits into from

Conversation

Jeremy-Hibiki
Copy link

close #5949

@Jeremy-Hibiki
Copy link
Author

Jeremy-Hibiki commented Aug 6, 2024

the api now returns { "body": [ ... ] }, without a nested "list" field

image

@Jeremy-Hibiki Jeremy-Hibiki changed the title [fanbox] fix list indices error [WIP] [fanbox] fix list indices error Aug 6, 2024
@Jeremy-Hibiki Jeremy-Hibiki changed the title [WIP] [fanbox] fix list indices error WIP: [fanbox] fix list indices error Aug 6, 2024
@Jeremy-Hibiki Jeremy-Hibiki marked this pull request as draft August 6, 2024 16:41
@Jeremy-Hibiki
Copy link
Author

Jeremy-Hibiki commented Aug 6, 2024

I found currently the post.listCreator endpoint returns a list inside body field, the others still composed by items and nextUrl fields.

With the change, the post.listCreator endpoint loose the ability to go next page. Maybe fanbox will update other APIs

@ZenoArrows
Copy link

ZenoArrows commented Aug 7, 2024

There's a new end point for pagination called post.paginateCreator that will give you a list of post.listCreator URLs that you can iterate over.

I've opened a PR that implements that endpoint: #5956

mikf added a commit that referenced this pull request Aug 7, 2024
@mikf mikf closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fanbox] list indices must be integers or slices, not str
3 participants