Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add tests #14

Merged
merged 17 commits into from
Oct 19, 2023
Merged

ci: add tests #14

merged 17 commits into from
Oct 19, 2023

Conversation

3LivesLeft
Copy link
Collaborator

No description provided.

@millnut
Copy link
Owner

millnut commented Oct 17, 2023

@3LivesLeft accessibility tests on an automated action work now. However it is flagging Card as an accessibility fail due to the use of <li> without a parent <ul> so we'll need to think how best to handle that as https://millnut.github.io/storybook_foundations/?path=/story/example-card--primary show an accessibility failure as well

I added a decorator to the story, which might be a solution to this;

export const Primary: Story = {
  args: {
    ...Card.defaultProps
  },
  decorators: [
    (Story) => (
      <ul>
        <Story />
      </ul>
    )
  ]
};

@3LivesLeft
Copy link
Collaborator Author

@millnut this is the correct solution. Happy to merge

@millnut millnut merged commit 13dec3a into main Oct 19, 2023
5 checks passed
@millnut millnut deleted the feature/tests branch October 19, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants