Add tenant namespace and auth parameters for external pulsar (#396)

Signed-off-by: Edward Zeng <jie.zeng@zilliz.com> Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
milvus-io · Dec 8, 2022 · d827848 · d827848
1 parent 8a1c4da
commit d827848
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/charts/milvus/Chart.yaml b/charts/milvus/Chart.yaml
@@ -3,7 +3,7 @@ name: milvus
 appVersion: "2.2.0"
 kubeVersion: "^1.10.0-0"
 description: Milvus is an open-source vector database built to power AI applications and vector similarity search.
-version: 3.3.2
+version: 3.3.3
 keywords:
   - milvus
   - elastic

diff --git a/charts/milvus/README.md b/charts/milvus/README.md
@@ -187,6 +187,10 @@ The following table lists the configurable parameters of the Milvus Service and
 | `externalPulsar.enabled`                  | Enable or disable external Pulsar             | `false`                                                 |
 | `externalPulsar.host`                     | The host of the external Pulsar               | `localhost`                                             |
 | `externalPulsar.port`                     | The port of the external Pulsar               | `6650`                                                  |
+| `externalPulsar.tenant`                   | The tenant of the external Pulsar             | `public`                                                  |
+| `externalPulsar.namespace`                | The namespace of the external Pulsar          | `default`                                                  |
+| `externalPulsar.authPlugin`               | The authPlugin of the external Pulsar         | `""`                                                  |
+| `externalPulsar.authParams`               | The authParams of the external Pulsar         | `""`                                                  |
 | `externalKafka.enabled`                   | Enable or disable external Kafka             | `false`                                                 |
 | `externalKafka.brokerList`                | The brokerList of the external Kafka separated by comma               | `localhost:9092`                                             |
 | `externalKafka.securityProtocol`          | The securityProtocol used for kafka authentication                    | `SASL_SSL`                                                   |

diff --git a/charts/milvus/templates/config.tpl b/charts/milvus/templates/config.tpl
@@ -108,6 +108,10 @@ pulsar:
   address: {{ .Values.externalPulsar.host }}
   port: {{ .Values.externalPulsar.port }}
   maxMessageSize: {{ .Values.externalPulsar.maxMessageSize }}
+  tenant: {{ .Values.externalPulsar.tenant }}
+  namespace: {{ .Values.externalPulsar.namespace }}
+  authPlugin: {{ .Values.externalPulsar.authPlugin }}
+  authParams: {{ .Values.externalPulsar.authParams }}
 
 {{- else if .Values.pulsar.enabled }}
 

diff --git a/charts/milvus/values.yaml b/charts/milvus/values.yaml
@@ -1050,6 +1050,10 @@ externalPulsar:
   host: localhost
   port: 6650
   maxMessageSize: 5242880  # 5 * 1024 * 1024 Bytes, Maximum size of each message in pulsar.
+  tenant: public
+  namespace: default
+  authPlugin: ""
+  authParams: ""
 
 ###################################
 # External kafka