Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use mmap.scalarIndex config for text index #36400

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

issue: #35273

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 20, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 20, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link
Contributor

mergify bot commented Sep 20, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.40%. Comparing base (eb23e23) to head (68f55eb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/storage/Types.h 50.00% 2 Missing ⚠️
internal/core/src/storage/storage_c.cpp 0.00% 2 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36400      +/-   ##
==========================================
- Coverage   82.34%   73.40%   -8.94%     
==========================================
  Files        1277     1277              
  Lines      150744   150746       +2     
==========================================
- Hits       124126   110654   -13472     
- Misses      21632    35110   +13478     
+ Partials     4986     4982       -4     
Files with missing lines Coverage Δ
internal/util/initcore/init_core.go 87.41% <100.00%> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% <0.00%> (-75.54%) ⬇️
internal/core/src/storage/Types.h 22.66% <50.00%> (-17.88%) ⬇️
internal/core/src/storage/storage_c.cpp 0.00% <0.00%> (-73.44%) ⬇️

... and 244 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants