Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glenn unification multiagent support #375

Merged
merged 18 commits into from
Aug 18, 2020

Conversation

glennpow
Copy link
Collaborator

There is currently an issue processing the info-dict, that I didn't have time to resolve, but otherwise it seems very close to working. You can run this from the root dir to test python tests/multiagent_test.py. When working, it should create the env with 2 agents and run an episode.

juliusfrost and others added 17 commits June 28, 2020 21:41
Gets rid of shutil.Error by not copying the cache.properties.lock
Removing unneeded Render command

Moved _find_server back to where it can still influence the xml.

Correctly tick client/server and process observations.

Branch using correct client-tick obs.

Fixed log once functionality.

Fixed the env stepper

Fixed issues syncing two clients and stepping envs.

Remove dead code.

Moved the multiagent test xmls and script to tests dir.  Fixed action handlers.

obs/ac are now dicts to match the interface of magym.
@glennpow glennpow requested a review from MadcowD August 17, 2020 22:56
@pep8speaks
Copy link

pep8speaks commented Aug 17, 2020

Hello @glennpow! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 103:80: E501 line too long (113 > 79 characters)
Line 225:80: E501 line too long (99 > 79 characters)
Line 233:80: E501 line too long (87 > 79 characters)
Line 234:20: E131 continuation line unaligned for hanging indent
Line 263:80: E501 line too long (103 > 79 characters)
Line 275:80: E501 line too long (88 > 79 characters)
Line 280:80: E501 line too long (88 > 79 characters)
Line 281:80: E501 line too long (92 > 79 characters)
Line 285:80: E501 line too long (90 > 79 characters)
Line 286:80: E501 line too long (88 > 79 characters)
Line 287:1: W293 blank line contains whitespace
Line 288:80: E501 line too long (91 > 79 characters)
Line 495:80: E501 line too long (93 > 79 characters)
Line 524:80: E501 line too long (107 > 79 characters)
Line 538:80: E501 line too long (81 > 79 characters)
Line 540:80: E501 line too long (81 > 79 characters)
Line 555:80: E501 line too long (91 > 79 characters)
Line 594:80: E501 line too long (81 > 79 characters)
Line 601:80: E501 line too long (85 > 79 characters)
Line 603:80: E501 line too long (112 > 79 characters)
Line 605:80: E501 line too long (89 > 79 characters)
Line 606:80: E501 line too long (88 > 79 characters)
Line 607:37: E127 continuation line over-indented for visual indent
Line 608:37: E127 continuation line over-indented for visual indent
Line 608:80: E501 line too long (87 > 79 characters)
Line 611:80: E501 line too long (85 > 79 characters)
Line 622:80: E501 line too long (89 > 79 characters)
Line 627:80: E501 line too long (84 > 79 characters)
Line 642:80: E501 line too long (104 > 79 characters)
Line 646:80: E501 line too long (124 > 79 characters)
Line 647:80: E501 line too long (120 > 79 characters)
Line 657:80: E501 line too long (101 > 79 characters)
Line 665:80: E501 line too long (81 > 79 characters)
Line 668:80: E501 line too long (100 > 79 characters)
Line 672:80: E501 line too long (126 > 79 characters)
Line 673:80: E501 line too long (116 > 79 characters)
Line 675:80: E501 line too long (106 > 79 characters)
Line 684:80: E501 line too long (88 > 79 characters)
Line 756:80: E501 line too long (93 > 79 characters)
Line 790:80: E501 line too long (81 > 79 characters)
Line 798:80: E501 line too long (101 > 79 characters)

Line 387:80: E501 line too long (96 > 79 characters)
Line 388:80: E501 line too long (87 > 79 characters)

Line 24:80: E501 line too long (91 > 79 characters)

Line 40:13: E128 continuation line under-indented for visual indent

Line 42:13: E128 continuation line under-indented for visual indent
Line 43:13: E128 continuation line under-indented for visual indent
Line 112:13: E128 continuation line under-indented for visual indent
Line 113:13: E128 continuation line under-indented for visual indent

Line 9:80: E501 line too long (83 > 79 characters)

Line 58:80: E501 line too long (101 > 79 characters)

Line 11:80: E501 line too long (97 > 79 characters)
Line 12:80: E501 line too long (111 > 79 characters)
Line 13:80: E501 line too long (113 > 79 characters)
Line 45:80: E501 line too long (91 > 79 characters)

Comment last updated at 2020-08-18 21:12:23 UTC

@MadcowD MadcowD merged commit d9163b9 into wguss/unification Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants