Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime.support_avx2 not defined #6

Closed
mdcnz opened this issue Apr 24, 2018 · 3 comments
Closed

runtime.support_avx2 not defined #6

mdcnz opened this issue Apr 24, 2018 · 3 comments
Assignees
@aead

Comments

@mdcnz
Copy link

mdcnz commented Apr 24, 2018

Hello,

It appears go test fails in highwayhash with a development version of go:

github.com/minio/highwayhash.supportsAVX2: relocation target runtime.support_avx2 not defined
github.com/minio/highwayhash.supportsAVX2: undefined: "runtime.support_avx2"

This is likely due to the recent removal of runtime.support_avx2. It was replaced with a cpu package runtime/internal/cpu.X86.HasAVX2.

This is with:
highwayhash version commit 9c7e959
go version devel +a3c75d9 Tue Apr 24 01:06:17 2018 +0000 linux/amd64

See this issue.
Possibly relevant change and another change.

Regards, Mark
@harshavardhana
Copy link
Member

We don't support devel yet @mdcnz - but thanks for opening the bug we will keep track. Let us know if you see any issues with go latest releases.

@aead aead self-assigned this Apr 30, 2018
@aead
Copy link
Member

aead commented Apr 30, 2018 •
edited
Loading

@mdcnz I'm aware of this problem. I've proposed and still work on a general cpu package at x/sys/cpu.
See: golang/go#24843

aead pushed a commit that referenced this issue Apr 30, 2018
replace custom CPU feature detection
342af21 
This change replaces the custom CPU feature detection code using
the new `x/sys/cpu` package.

Fixes #6
@aead aead mentioned this issue Apr 30, 2018
Merged
@mdcnz
Copy link
Author

mdcnz commented Apr 30, 2018

Thanks @aead, in my case that fixes the issue.

@aead aead closed this as completed in #7 May 1, 2018
aead pushed a commit that referenced this issue May 1, 2018
replace custom CPU feature detection (#7)
85fc8a2 
This change replaces the custom CPU feature detection code using
the new `x/sys/cpu` package.

Fixes #6
@dvzrv dvzrv mentioned this issue Oct 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aead aead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@harshavardhana @mdcnz @aead