fix replication validation for Role ARN (#1978)

minio · Jun 26, 2024 · e0ba2df · e0ba2df
1 parent b28095b
commit e0ba2df
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/replication/replication.go b/pkg/replication/replication.go
@@ -406,6 +406,9 @@ func (c *Config) EditRule(opts Options) error {
 			return fmt.Errorf("priority must be unique. Replication configuration already has a rule with this priority")
 		}
 		if rule.Destination.Bucket != newRule.Destination.Bucket && rule.ID == newRule.ID {
+			if c.Role == newRule.Destination.Bucket {
+				continue
+			}
 			return fmt.Errorf("invalid destination bucket for this rule")
 		}
 	}

diff --git a/pkg/replication/replication_test.go b/pkg/replication/replication_test.go
@@ -180,7 +180,7 @@ func TestEditReplicationRule(t *testing.T) {
 				StorageClass: "STANDARD",
 				DestBucket:   "arn:minio:replication:eu-west-1:c5acb6ac-9918-4dc6-8534-6244ed1a611a:destbucket",
 			},
-			expectedErr: "invalid destination bucket for this rule",
+			expectedErr: "",
 		},
 		{ // test case :2 mismatched rule id
 			cfg: Config{