Use formatted domain name when assigning to domain (#175)

This formatting was introduced when we create the domains, but the assign step needs to be consistent.
ministryofjustice · Jul 3, 2024 · fad1a12 · fad1a12
1 parent cc8395c
commit fad1a12
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ingestion/dbt_manifest_utils.py b/ingestion/dbt_manifest_utils.py
@@ -60,7 +60,7 @@ def convert_cadet_manifest_table_to_datahub(node_info: dict) -> Tuple[str, str]:
     eg 'database__table' is converted to a regex string to detect it's urn
     like 'urn:li:dataset:\\(urn:li:dataPlatform:dbt,cadet\\.awsdatacatalog\\.database\\.table,PROD\\)'
     """
-    domain = node_info.get("fqn", [])[1]
+    domain = format_domain_name(node_info.get("fqn", [])[1])
     node_table_name = node_info.get("fqn", [])[-1]
 
     # In CaDeT the convention is to name a table database__table

diff --git a/tests/test_assign_cadet_domains.py b/tests/test_assign_cadet_domains.py
@@ -26,7 +26,7 @@ def test_pattern_add_dataset_domain_aspect_name(self, mock_datahub_graph):
         assert transformer.aspect_name() == models.DomainsClass.ASPECT_NAME
 
     def test_pattern_add_dataset_domain_match(self, mock_datahub_graph):
-        prison_domain = builder.make_domain_urn("prison")
+        prison_domain = builder.make_domain_urn("Prison")
 
         pipeline_context: PipelineContext = PipelineContext(
             run_id="test_simple_add_dataset_domain"
@@ -53,8 +53,8 @@ def test_pattern_add_dataset_domain_match(self, mock_datahub_graph):
         assert prison_domain in transformed_aspect.domains
 
     def test_pattern_add_dataset_domain_overwrite(self, mock_datahub_graph):
-        prison_domain = builder.make_domain_urn("prison")
-        probation_domain = builder.make_domain_urn("probation")
+        prison_domain = builder.make_domain_urn("Prison")
+        probation_domain = builder.make_domain_urn("Probation")
 
         pipeline_context: PipelineContext = PipelineContext(
             run_id="test_simple_add_dataset_domain"