Better defaults for contact info panel #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if there is a data owner, direct users to them - if not, this is probably a bug with ingestion. show "Not provided" in this case hypothesis - this will get missing metadata issues fixed more quickly
In order to present a consistent contact info panel, we should always show each of the three metadata fields, falling back to a "Not provided" value if missing. If access information or contact information is missing, direct the user to the data owner. When this happens we would also like the data owner to add in the missing metadata. If the data owner is missing, then direct the user to us. We do not intend to show any metadata without a data owner, so this should be treated as a bug in the service. part of #601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #601
In order to present a consistent contact info panel, we should always show each of the three metadata fields, falling back to a "Not provided" value if missing.
If access information or contact information is missing, direct the user to the data owner. When this happens we would also like the data owner to add in the missing metadata.
If the data owner is missing, then direct the user to us. We do not intend to show any metadata without a data owner, so this should be treated as a bug in the service.
Examples
All metadata missing
Access information missing
Contact channels missing