fix: unite reusable push and deploy jobs for single stage during workflow, mask image_path, fix docker tag statement env reference
#714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow, mask `image_path`, fix `docker tag` statement env reference
murdo-moj
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the goals of #590 is to unite workflows so there is only 1 approval required per environment. For that to work,
pushanddeployworkflow jobs need to be united, as both would require approval for protected environments. This PR fixes that oversight.This PR also adds a mask to the sensitive
image_pathenv var, and attempts to fix a bug withdocker tagstep that isn't interpolating the provided env var.