ci: move prod deploy back into staged workflow #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
force-pushed
the
combine-prod-and-staged-workflow
branch
from
1bdf538
to
8997432
Compare
We initially thought that we should trigger prod deploys on release, as this would force us to write release notes for everything we deploy. This idea didn't work: 1. it made it difficult to prevent skipping the earlier stages of the workflow 2. it forces every prod deploy to be a release, even if nothing user-facing has changed This commit moves the prod release back into the deploy-staged workflow. To help us with release notes, it automatically generates a draft release, which we can then edit and publish. I've moved this to the very end of the workflow, to give teams reusing this code the assurance that anything we publish as a release is already running in Find MoJ data prod.
MatMoore
force-pushed
the
combine-prod-and-staged-workflow
branch
from
8997432
to
616596f
Compare
murdo-moj
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially thought that we should trigger prod deploys on release, as this would force us to write release notes for everything we deploy.
This idea didn't work:
This commit moves the prod release back into the deploy-staged workflow.
To help us with release notes, it automatically generates a draft release, which we can then edit and publish. I've moved this to the very end of the workflow, to give teams reusing this code the assurance that anything we publish as a release is already running in Find MoJ data prod.