Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add back button to cookie page #728

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

tom-webber
Copy link
Contributor

@tom-webber tom-webber commented Aug 28, 2024

The cookies page is viewable from any page in the application, but is likely not an endpoint for users, so they will want to be able to navigate back to their previous page.

The cookie view has been added to home/views.py, and the referer URL is validated to ensure the URL is one of the trusted domains (i.e. is within settings.CSRF_TRUSTED_ORIGINS).

localhost has been added to settings.CSRF_TRUSTED_ORIGINS when running with settings.DEBUG == True

The cookies page is viewable from any page in the application, but is likely not an endpoint for users, so they will want to be able to navigate back to their previous page.

The cookie view has been added to `home/views.py`, and the referer URL is validated to ensure the URL is one of the trusted domains (i.e. is within `settings.CSRF_TRUSTED_ORIGINS`).

localhost has been added to `settings.CSRF_TRUSTED_ORIGINS` when running with `settings.DEBUG == True`
@tom-webber tom-webber requested a review from a team as a code owner August 28, 2024 09:38
@tom-webber tom-webber mentioned this pull request Aug 28, 2024
@tom-webber tom-webber merged commit 0ebfc8c into main Aug 29, 2024
1 check passed
@tom-webber tom-webber deleted the fmd-622-add-back-button-cookie-page branch August 29, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants