Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update notifications to match new workflow structure #758

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Sep 3, 2024

The notifications workflow is triggered by other workflows completing, but requires the names to match. The rename should fix the prod notifications that stopped work.

Since we have now included prod in the staged workflow, this can no longer detect when preprod has finished. To workaround this, I've moved the preprod notifications directly into the staged workflow.

@MatMoore MatMoore marked this pull request as ready for review September 4, 2024 13:46
@MatMoore MatMoore requested a review from a team as a code owner September 4, 2024 13:46
Copy link
Collaborator

@mitchdawson1982 mitchdawson1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatMoore MatMoore merged commit c3c4203 into main Sep 4, 2024
10 checks passed
@MatMoore MatMoore deleted the fix-notifications branch September 4, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants