Handle output_directory and change_directory properly #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If option change_directory is used output_directory should be relative to the new pwd (in current implementation that would be `.` always) or use absolute path. In addition if option change_directory is used flag `-output-directory` doesn't need to be set on the tex compilation command. This implements this behaviour by setting `options.output_directory` to `nil` (so that `-output-directory` will not be set later) after generating the init lua script.
|
Merged. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If option change_directory is used output_directory should be relative
to the new pwd (in current implementation that would be
.always) oruse absolute path. In addition if option change_directory is used flag
-output-directorydoesn't need to be set on the tex compilationcommand.
This implements this behaviour by setting
options.output_directorytonil(so that-output-directorywill not be set later) aftergenerating the init lua script.
Addresses #7
I'm not quite sure about the
options.output_directoryhandling. Maybe it would be nicer iftex_enginewould respect thechange_directoryoption to achieve a more consistenttex_options. On the other hand having achange_directoryoption fortex_enginejust to avoid setting the-output-directoryflag on the tex command isn't that nice either.I hope these are all spots which were causing the
change_directorytrouble.