Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly handle default configuration when user dirs do not exist #222

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Conan-Kudo
Copy link
Collaborator

We assumed that the user configuration directory hierarchy always exists, but with a completely fresh installation, it does not.

Consequently, populating the default configuration silently failed and the environment is broken.

To resolve this issue, we now check to see if the directory the configuration file lives in exists, and we create it if it does not.

Additionally, we now support populating a full set of default configuration in case multiple files and folders are required for initial configuration.

We assumed that the user configuration directory hierarchy always
exists, but with a completely fresh installation, it does not.

Consequently, populating the default configuration silently failed
and the environment is broken.

To resolve this issue, we now check to see if the directory the
configuration file lives in exists, and we create it if it does not.

Additionally, we now support populating a full set of default
configuration in case multiple files and folders are required for
initial configuration.
@Conan-Kudo
Copy link
Collaborator Author

This should hopefully fix rhbz#2308337.

Copy link
Collaborator

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@mattkae mattkae merged commit b4fa88e into miracle-wm-org:develop Aug 28, 2024
2 checks passed
@Conan-Kudo Conan-Kudo deleted the fix/default-config-setup branch August 28, 2024 15:09
mattkae pushed a commit that referenced this pull request Sep 7, 2024
…st (#222)

We assumed that the user configuration directory hierarchy always
exists, but with a completely fresh installation, it does not.

Consequently, populating the default configuration silently failed
and the environment is broken.

To resolve this issue, we now check to see if the directory the
configuration file lives in exists, and we create it if it does not.

Additionally, we now support populating a full set of default
configuration in case multiple files and folders are required for
initial configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants