forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3 from mistic/node-version-validator-#12976-pr-re…
…view Node version validator elastic#12976 pr review 3
- Loading branch information
Showing
7 changed files
with
49 additions
and
186 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,18 @@ | ||
var pkg = require('../../package.json'); | ||
|
||
// Note: This is written in ES5 so we can run this before anything else | ||
// and gives support for older NodeJS versions | ||
var NodeVersion = require('../utils/node_version'); | ||
var currentVersion = (process && process.version) || null; | ||
var rawRequiredVersion = (pkg && pkg.engines && pkg.engines.node) || null; | ||
var requiredVersion = rawRequiredVersion ? 'v' + rawRequiredVersion : rawRequiredVersion; | ||
var isVersionValid = !!currentVersion && !!requiredVersion && (currentVersion === requiredVersion); | ||
|
||
// Validates current the NodeJS version compatibility when Kibana starts. | ||
NodeVersion.runValidator(function () { | ||
// Action to apply when validation fails: error report + exit. | ||
console.error( | ||
`Kibana does not support the current Node.js version ${NodeVersion.getCurrentVersion()}. ` | ||
+ `Please use Node.js ${NodeVersion.getRequiredVersion()}.` | ||
); | ||
if (!isVersionValid) { | ||
var errorMessage = 'Kibana does not support the current Node.js version ' + currentVersion | ||
+ '. Please use Node.js ' + requiredVersion + '.'; | ||
|
||
// Actions to apply when validation fails: error report + exit. | ||
console.error(errorMessage); | ||
process.exit(1); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
var exec = require('child_process').exec; | ||
var pkg = require('../../package.json'); | ||
|
||
var REQUIRED_NODE_JS_VERSION = 'v' + pkg.engines.node; | ||
var INVALID_NODE_JS_VERSION = 'v0.10.0'; | ||
|
||
describe('NodeVersionValidator', function () { | ||
|
||
it('should run the script WITH error', function (done) { | ||
var processVersionOverwrite = 'Object.defineProperty(process, \'version\', { value: \'' | ||
+ INVALID_NODE_JS_VERSION + '\', writable: true });'; | ||
var command = 'node -e "' + processVersionOverwrite + 'require(\'./node_version_validator.js\')"'; | ||
|
||
exec(command, { cwd: __dirname }, function (error, stdout, stderr) { | ||
expect(error.code).toBe(1); | ||
expect(stderr).toBeDefined(); | ||
expect(stderr).not.toHaveLength(0); | ||
done(); | ||
}); | ||
}); | ||
|
||
it('should run the script WITHOUT error', function (done) { | ||
var processVersionOverwrite = 'Object.defineProperty(process, \'version\', { value: \'' | ||
+ REQUIRED_NODE_JS_VERSION + '\', writable: true });'; | ||
var command = 'node -e "' + processVersionOverwrite + 'require(\'./node_version_validator.js\')"'; | ||
|
||
exec(command, { cwd: __dirname }, function (error, stdout, stderr) { | ||
expect(error).toBeNull(); | ||
expect(stderr).toBeDefined(); | ||
expect(stderr).toHaveLength(0); | ||
done(); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.