This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Support go1.13 -trimpath option #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - This worked great for me. Thanks @aprice. |
dropwhile
added a commit
to cactus/go-camo
that referenced
this pull request
Sep 8, 2019
this allows passing GOBUILD_OPTIONS=-trimpath, which isn't supported by gox mainline yet. Support for it is in a PR[1] though. [1]: mitchellh/gox#138
mvdan
approved these changes
Sep 22, 2019
|
Here's a temporary workaround: Arguably, we could use |
| @@ -221,6 +223,7 @@ Options: | |||
| -parallel=-1 Amount of parallelism, defaults to number of CPUs | |||
| -gocmd="go" Build command, defaults to Go | |||
| -rebuild Force rebuilding of package that were up to date | |||
| -trimpath Remove all file system paths from the resulting executable | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick change to allow passing through the new -trimpath build option added in Go 1.13.