Fix workspace with default root, simplify lots walkers & metadata #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On top of mitsuhiko#531; that needs to merge first. This simplifies that code
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Jul 28, 2024
It was previously a bit disparate and difficult to verify. This simplifies & unifies the code. It builds on mitsuhiko#532, so that should merge first.
max-sixty
added a commit
to max-sixty/insta
that referenced
this pull request
Aug 2, 2024
This splits out the changes in the test code from mitsuhiko#532 in order to make that diff smaller. It divides the building of the test case files from the test case files on disk + running the test, which make the structs simpler & more obvious
max-sixty
added a commit
that referenced
this pull request
Aug 2, 2024
This splits out the changes in the test code from #532 in order to make that diff smaller. It divides the building of the test case files from the test case files on disk + running the test, which make the structs simpler & more obvious
This adds the tests from mitsuhiko#532 into the repo so we can compare the changes between existing `master` and the new code. One test panics, which is tagged here (and we wil remove in mitsuhiko#532)
max-sixty
added a commit
that referenced
this pull request
Aug 2, 2024
max-sixty
changed the title
|
@mitsuhiko if you're happy with this, I think we could merge and then release 1.40... (maybe also #482 if you're happy with it, but less immediacy...) |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #531; that needs to merge first. This simplifies that codeOK so:
cargo test --accept --workspaceon a workspace with a default crate and other members. It fixes that bug, and removes the#[should_panic]attribute on that test. None of the previously correct behavior changes.I realize it was a bit messy to get here. Hopefully now that we have tests, it's easier to review small changes to code, and we don't have quite so many slightly-overlapping changes pending at the same time. I do think some of the code was getting needlessly complicated and this makes it much simpler, as well as fixing the bug. (But ofc very open to suggested changes!)