Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commonmark spec from upstream (and reflect its changes) #208

Merged
merged 6 commits into from
Jan 28, 2024
Merged

Conversation

mity
Copy link
Owner

@mity mity commented Jan 9, 2024

This PR uses (yet unreleased) Commonmark specification from the spec repo and implements changes mandated by it.

Quite possibly won't be merged into trunk until the next spec version gets released.

Update: spec 0.31 has been released.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bd6224) 91.75% compared to head (584d389) 91.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   91.75%   91.76%   +0.01%     
==========================================
  Files           5        5              
  Lines        3410     3402       -8     
==========================================
- Hits         3129     3122       -7     
+ Misses        281      280       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mity mity force-pushed the specupd branch 3 times, most recently from 05eab34 to aac6db0 Compare January 11, 2024 09:41
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@mity mity force-pushed the specupd branch 4 times, most recently from fc0f0bf to 757e909 Compare January 11, 2024 11:42
Namely all P and S general categories are now treated as punctuation.
* Accept "<!-->" and "<!--->" as valid HTML comments.
* HTML comment now can contain "--"
Specifically, "<source>" has been removed, "<search>" added.
@mity mity changed the title [WIP] Update commonmark spec from upstream (and reflect its changes) Update commonmark spec from upstream (and reflect its changes) Jan 28, 2024
@mity
Copy link
Owner Author

mity commented Jan 28, 2024

cc @ec1oud

Spec 0.31 has just been released. This changes my plans: Will make release as soon as I get some confidence the quality (with this PR) is no worse than 0.5.1.

The respective changes in code (other than update of the punctuation table) very local and quite benign so I don't expect troubles.

@mity mity merged commit 06b3ad8 into master Jan 28, 2024
12 checks passed
@mity mity deleted the specupd branch January 28, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant