Merge pull request #15 from mjanardhan/fix-ray-integ-tests

WorkerType and numberofWorkers defaults are enforced when not set
mjanardhan · Jul 23, 2024 · 79339c4 · 79339c4
2 parents df4b1d0 + c077b11
commit 79339c4
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 30 deletions.
diff --git a/packages/@aws-cdk/aws-glue-alpha/lib/jobs/ray-job.ts b/packages/@aws-cdk/aws-glue-alpha/lib/jobs/ray-job.ts
@@ -75,10 +75,6 @@ export class RayJob extends Job {
       throw new Error('Ray jobs only support Z.2X worker type');
     };
 
-    if ((!props.workerType && props.numberOfWorkers !== undefined) || (props.workerType && props.numberOfWorkers === undefined)) {
-      throw new Error('Both workerType and numberOFWorkers must be set');
-    }
-
     const jobResource = new CfnJob(this, 'Resource', {
       name: props.jobName,
       description: props.description,

diff --git a/packages/@aws-cdk/aws-glue-alpha/test/ray-job.test.ts b/packages/@aws-cdk/aws-glue-alpha/test/ray-job.test.ts
@@ -62,12 +62,6 @@ describe('Job', () => {
         }),
       });
     });
-
-    test('Default numberOfWorkers should be 3', () => {
-      Template.fromStack(stack).hasResourceProperties('AWS::Glue::Job', {
-        NumberOfWorkers: 3,
-      });
-    });
   });
 
   describe('Create new Ray Job with log override parameters', () => {
@@ -264,25 +258,5 @@ describe('Job', () => {
         });
       }).toThrow(new Error('Ray jobs only support Z.2X worker type'));
     });
-
-    test('Create Ray Job overriding only workerType to cause an Error', () => {
-      expect(() => {
-        job = new glue.RayJob(stack, 'RayJob', {
-          role,
-          script,
-          workerType: glue.WorkerType.Z_2X,
-        });
-      }).toThrow(new Error('Both workerType and numberOFWorkers must be set'));
-    });
-
-    test('Create Ray Job overriding only numberOfWorkers to cause an Error', () => {
-      expect(() => {
-        job = new glue.RayJob(stack, 'RayJob', {
-          role,
-          script,
-          numberOfWorkers: 5,
-        });
-      }).toThrow(new Error('Both workerType and numberOFWorkers must be set'));
-    });
   });
 });