Etl jobs #6
Merged
Etl jobs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moomindani
reviewed
Jun 11, 2024
| bucket.grantReadWrite(role, cleanSparkUiPrefixForGrant(sparkUiProps.prefix)); | ||
| const args = { | ||
| '--enable-spark-ui': 'true', | ||
| '--spark-event-logs-path': bucket.s3UrlForObject(sparkUiProps.prefix), |
There was a problem hiding this comment.
Don't rollback the fix available on the upstream.
https://github.com/aws/aws-cdk/pull/29357/files
There was a problem hiding this comment.
Thanks, this is a great call-out
There was a problem hiding this comment.
This should be addressed in the next PR to this repo. Thanks again for catching this as we are further behind the upstream than we ever intended to be.
| @@ -16,6 +16,7 @@ export * from './constants'; | |||
| export * from './jobs/job'; | |||
| // export * from './jobs/flex-job'; | |||
| export * from './jobs/pyspark-etl-job'; | |||
| export * from './jobs/scala-spark-etl-job'; | |||
| // export * from './jobs/python-shell-job'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #.
Reason for this change
Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license