forked from ckan/ckan-docker-base
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using CKAN Backports Repository for Building Images >2.9.11 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use while loop for restarting dev
debugpy support for VS Code remote debugging
Upgrade db like the console text says
uninstall src packages found in src_extensions
fix for master packaging uninstall error
- Bump DataPusher version - Listen on an IPv6 unspecified address (rather than IPv4) - Set up timezone to get rid of warning messages
- CKAN 2.10 and master uwsgi processes to listen on ipv6 - CKAN 2.9 to remain on ipv4
No need to reference a python specific details
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
Co-authored-by: Adrià Mercader <amercadero@gmail.com>
Use ckan/ckan-base:2.9.11-py3.9 for the base image (rather than .py3.10)
Update Dockerfile.py3.9 for CKAN 2.9 (dev)
It's not clear we are using this, and they were installing a system-wide packaging package that could not be uninstalled when installing CKAN requirements: error: uninstall-distutils-installed-package Cannot uninstall packaging 21.3 ╰─> It is a distutils installed project and thus we cannot accurately...
- Alpine legacy images (Dockerfile) - New Python images (py3.*)
- Align with ckan/ckan-docker-base updates. (Fix setup files) - Add proj to base Dockerfiles - Add Dockerfile.py3.* to ckan-2.9 and ckan-2.10 - Improve test images using the official ckan-base images
- Updated the "Determine Python Dockerfile" step to output only the filename instead of the full path. - This change ensures that subsequent steps referencing the Dockerfile do not fail due to incorrect paths. - Adjusted the `find` command to extract just the filename using `basename`.
- Switched to a lighter base image: python:3.10-slim-bookworm - Consolidated multiple RUN commands to reduce the number of layers - Cleaned up apt cache and removed unnecessary files to reduce image size - Used --no-cache-dir with pip to avoid caching packages - Defined environment variables at the beginning for easier configuration - Grouped related commands together to improve readability and maintainability - Ensured locale and timezone settings are configured in a single RUN command
- Add determine Dockerfile to dev images - Fix suffix_tag generation.
- Add image build & push for Dockerfile and Dockerfile.py3.* - Improve PR checks - Improve manual workflow
- Align ckan-docker-spatial from ckan-docker-base - Add ckan-2.11 - Improve ckan-2.9 and ckan-2.10 images with Debian-based Python images instead of Alpine #70
mjanez
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using CKAN Backports Repository for Building Images >2.9.11
Description
This PR introduces the use of the CKAN backports repository for building CKAN images for versions greater than 2.9.11. Below is an explanation of why this change is necessary.
Changes Introduced
In the
Dockerfile
, the following lines have been added:ckan-docker-spatial/ckan-2.9/base/Dockerfile
Lines 13 to 16 in 45c6271
Justification
Versions of CKAN greater than 2.9.11 require certain patches and improvements that are not present in the main CKAN repository. To address these issues and ensure the stability and functionality of CKAN, a backports repository has been created that includes these necessary changes.
Compatibility and Stability: The backports repository contains patches and improvements that ensure versions greater than 2.9.11 work correctly. This includes bug fixes and security enhancements that are not available in the main repository.
Ease of Maintenance: By centralizing these changes in a specific repository, it becomes easier to maintain and update CKAN images. This allows for the quick application of new patches and improvements without affecting the stability of previous versions.
Flexibility in Image Building: Using environment variables (
GIT_ORG
,GIT_REPO
,GIT_URL
, we allow greater flexibility in building the images. This makes it easier to change the source of the code if necessary without modifying theDockerfile
.Conclusion
Using the CKAN backports repository for versions greater than 2.9.11 is a necessary measure to ensure the compatibility, stability, and ease of maintenance of CKAN images. This approach allows for the quick application of patches and improvements, ensuring that the latest versions of CKAN work correctly in production environments.
Please review and approve these changes to improve the building and maintenance of our CKAN images.
References