fix: handle internal package.json file, with a non valid package name

Close #553

package.json

@@ -40,6 +40,7 @@
     "magic-string": "0.25.7",
     "mkdirp": "1.0.4",
     "moment": "2.25.1",
+    "package-name-regex": "1.0.8",
     "spdx-expression-validate": "2.0.0",
     "spdx-satisfies": "5.0.0"
   },

src/license-plugin.js

@@ -29,6 +29,7 @@ import _ from 'lodash';
 import moment from 'moment';
 import MagicString from 'magic-string';
 import glob from 'glob';
+import packageNameRegex from 'package-name-regex';
 
 import {Dependency} from './dependency.js';
 import {generateBlockComment} from './generate-block-comment.js';
@@ -176,7 +177,11 @@ class LicensePlugin {
 
         // We are probably in a package.json specifying the type of package (module, cjs).
         // Nevertheless, if the package name is not defined, we must not use this `package.json` descriptor.
-        if (pkgJson.name) {
+        const license = pkgJson.license || pkgJson.licenses;
+        const hasLicense = license && license.length > 0;
+        const name = pkgJson.name;
+        const isValidPackageName = name && packageNameRegex.test(name);
+        if (isValidPackageName || hasLicense) {
           // We found it!
           pkg = pkgJson;
 

test/fixtures/fake-package-6/index.js

@@ -0,0 +1 @@
+export {test} from './internal/index';

test/fixtures/fake-package-6/internal/index.js

@@ -0,0 +1,3 @@
+export function test() {
+  return true;
+}

test/fixtures/fake-package-6/internal/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "@fake-package/core/internal",
+  "private": true
+}

test/fixtures/fake-package-6/package.json

@@ -0,0 +1,15 @@
+{
+  "name": "fake-package",
+  "version": "1.0.0",
+  "description": "Fake package used in unit tests",
+  "main": "src/index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "author": "Mickael Jeanroy <mickael.jeanroy@gmail.com>",
+  "license": "MIT",
+  "private": true,
+  "dependencies": {
+    "lodash": "*"
+  }
+}

test/fixtures/fake-package-7/index.js

@@ -0,0 +1 @@
+export {test} from './internal/index';

test/fixtures/fake-package-7/internal/index.js

@@ -0,0 +1,3 @@
+export function test() {
+  return true;
+}

test/fixtures/fake-package-7/internal/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "@fake-package/core/internal",
+  "private": true,
+  "license": "MIT"
+}

test/fixtures/fake-package-7/package.json

@@ -0,0 +1,15 @@
+{
+  "name": "fake-package",
+  "version": "1.0.0",
+  "description": "Fake package used in unit tests",
+  "main": "src/index.js",
+  "scripts": {
+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "author": "Mickael Jeanroy <mickael.jeanroy@gmail.com>",
+  "license": "MIT",
+  "private": true,
+  "dependencies": {
+    "lodash": "*"
+  }
+}

test/license-plugin.spec.js

@@ -144,6 +144,40 @@ describe('LicensePlugin', () => {
       });
     });
 
+    it('should load pkg and going up directories until a valid package name is found', () => {
+      const id = path.join(__dirname, 'fixtures', 'fake-package-6', 'internal', 'index.js');
+      const result = plugin.scanDependency(id);
+
+      expect(result).not.toBeDefined();
+      expect(addDependency).toHaveBeenCalled();
+      expect(plugin._dependencies).toEqual({
+        'fake-package': fakePackage,
+      });
+    });
+
+    it('should load pkg and going up directories until a package name with a license is found even with a non valid package name', () => {
+      const id = path.join(__dirname, 'fixtures', 'fake-package-7', 'internal', 'index.js');
+      const result = plugin.scanDependency(id);
+
+      expect(result).not.toBeDefined();
+      expect(addDependency).toHaveBeenCalled();
+      expect(plugin._dependencies).toEqual({
+        '@fake-package/core/internal': {
+          name: '@fake-package/core/internal',
+          maintainers: [],
+          version: null,
+          description: null,
+          repository: null,
+          homepage: null,
+          private: true,
+          license: 'MIT',
+          licenseText: null,
+          author: null,
+          contributors: [],
+        },
+      });
+    });
+
     it('should load pkg including license text from LICENSE.md file', () => {
       const id = path.join(__dirname, 'fixtures', 'fake-package-2', 'src', 'index.js');
       const result = plugin.scanDependency(id);