feat: add types #741
Merged
feat: add types #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke-zhang-04 <luke.zhang2004dev@gmail.com>
Signed-off-by: Luke-zhang-04 <luke.zhang2004dev@gmail.com>
Signed-off-by: Luke-zhang-04 <luke.zhang2004dev@gmail.com>
Signed-off-by: Luke-zhang-04 <luke.zhang2004dev@gmail.com>
Signed-off-by: Luke-zhang-04 <luke.zhang2004dev@gmail.com>
|
@Luke-zhang-04 Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful because it provides auto completion and built in documentation in many editors, which helps with setting up the plugin. A lot of other plugins come with type definitions and documentation comments.
Some types and comments are probably missing, since I have a limited understanding of this plugin. My definitions and comments are based off the README file and license-plugin-option.js. I was hoping you could fill in any gaps and release it. Thanks!