Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.StorageCache to add vers…
Browse files Browse the repository at this point in the history
…ion stable/2020-10-01 (Azure#12572)

* Address s360 errors updating fields names to match the RP and add missing field.

* Correct additional s360 errors while breaking changes window is open and correct spelling error found by spell checker.
  • Loading branch information
brpanask authored and mkarmark committed Jul 20, 2021
1 parent 46c8e6b commit 0042279
Show file tree
Hide file tree
Showing 15 changed files with 104 additions and 122 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,23 @@
"type": "object",
"description": "The error detail of the operation if any.",
"$ref": "#/definitions/ErrorResponse"
},
"properties": {
"x-ms-client-flatten": true,
"description": "Additional operation specific properties",
"$ref": "#/definitions/AscOperationProperties"
}
}
},
"AscOperationProperties": {
"type": "object",
"description": "Operation specific output",
"properties": {
"output": {
"description": "Additional Operation Specific Properties",
"additionalProperties": {
"type": "object"
}
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
}
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"credentials": {
"bindDn": "cn=ldapadmin,dc=contosoad,dc=contoso,dc=local",
"bindPassword": "<bindPassword>"
Expand Down Expand Up @@ -140,12 +140,12 @@
"domainJoined": "No"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down Expand Up @@ -232,12 +232,12 @@
"domainJoined": "Yes"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
},
"directoryServicesSettings": {
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"credentials": {
"bindDn": "cn=ldapadmin,dc=contosoad,dc=contoso,dc=local",
"bindPassword": "<bindPassword>"
Expand Down Expand Up @@ -121,12 +121,12 @@
},
"directoryServicesSettings": {
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down Expand Up @@ -205,12 +205,12 @@
},
"directoryServicesSettings": {
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,8 @@
"api-version": "2020-10-01"
},
"responses": {
"200": {
"body": ""
},
"202": {
"body": ""
},
"204": {
"body": ""
}
"200": {},
"202": {},
"204": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,8 @@
"api-version": "2020-10-01"
},
"responses": {
"200": {
"body": ""
},
"202": {
"body": ""
},
"204": {
"body": ""
}
"200": {},
"202": {},
"204": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@
"domainJoined": "Yes"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@
"domainJoined": "Yes"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down Expand Up @@ -169,12 +169,12 @@
"domainJoined": "Yes"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "AD",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "",
"ldapBaseDn": "",
"ldapBaseDN": "",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@
"domainJoined": "Yes"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down Expand Up @@ -170,12 +170,12 @@
"domainJoined": "Yes"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "AD",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "",
"ldapBaseDn": "",
"ldapBaseDN": "",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,8 @@
"api-version": "2020-10-01"
},
"responses": {
"200": {
"body": ""
},
"202": {
"body": ""
},
"204": {
"body": ""
}
"200": {},
"202": {},
"204": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,8 @@
"api-version": "2020-10-01"
},
"responses": {
"200": {
"body": ""
},
"202": {
"body": ""
},
"204": {
"body": ""
}
"200": {},
"202": {},
"204": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"domainNetBiosName": "contosoAd"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "AD"
}
}
Expand Down Expand Up @@ -176,12 +176,12 @@
"domainJoined": "Yes"
},
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "AD",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "",
"ldapBaseDn": "",
"ldapBaseDN": "",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@
},
"directoryServicesSettings": {
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"credentials": {
"bindDn": "cn=ldapadmin,dc=contosoad,dc=contoso,dc=local",
"bindPassword": "<bindPassword>"
Expand Down Expand Up @@ -167,12 +167,12 @@
},
"directoryServicesSettings": {
"usernameDownload": {
"extendedGroupsEnabled": true,
"extendedGroups": true,
"usernameSource": "LDAP",
"groupFileURI": "",
"userFileURI": "",
"ldapServer": "192.0.2.12",
"ldapBaseDn": "dc=contosoad,dc=contoso,dc=local",
"ldapBaseDN": "dc=contosoad,dc=contoso,dc=local",
"encryptLdapConnection": false,
"requireValidCertificate": false,
"autoDownloadCertificate": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,8 @@
"api-version": "2020-10-01"
},
"responses": {
"201": {
"body": ""
},
"202": {
"body": ""
},
"204": {
"body": ""
}
"201": {},
"202": {},
"204": {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,8 @@
"storageTargetName": "st1"
},
"responses": {
"200": {
"body": ""
},
"202": {
"body": ""
},
"204": {
"body": ""
}
"200": {},
"202": {},
"204": {}
}
}
Loading

0 comments on commit 0042279

Please sign in to comment.