Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmr version and modification in the cython interface #27

Merged
merged 14 commits into from
Feb 24, 2024

Conversation

xuluze
Copy link

@xuluze xuluze commented Feb 23, 2024

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@xuluze
Copy link
Author

xuluze commented Feb 23, 2024

There are still issues when I build this version:
(1) After rebuilding sage, it shows Warning: sage.all is not available; this is a limited REPL.
Maybe this is a reason that I cannot run ./sage -t src/sage/matrix/matrix_cmr_sparse.pyx, which outputs error message:

File "sage/matrix/matrix_integer_dense.pyx", line 1, in init sage.matrix.matrix_integer_dense
ImportError: /home/xuluze/mambaforge/envs/sage-cmr/lib/libffpack.so.1: undefined symbol: _ZN5FFLAS7fscalinIN6Givaro15ModularBalancedIfEEEEvRKT_mmNS4_7ElementENS4_11Element_ptrEm

(2) Some functions in cmr.pxd from matroid.h is commented out, for example, CMRmatroiddecGraphForest.
This is because some error occurs like:
'CMR_ELEMENT' is not a type identifier
'CMR_GRAPH_EDGE' is not a type identifier

(3) CMRdecIsSpecialLeaf and CMRdecIsSum does not have a matroiddec replacement yet, but we may need to test if it is available in other updated functions

@xuluze xuluze marked this pull request as draft February 23, 2024 20:17
@mkoeppe
Copy link
Owner

mkoeppe commented Feb 23, 2024

To fix the importerror, try what is documented here (https://deploy-preview-37411--sagemath.netlify.app/html/en/installation/source#caveats-when-upgrading-system-packages) to fix the build

@mkoeppe mkoeppe merged commit b342dd3 into mkoeppe:cmr Feb 24, 2024
8 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants