Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for CPU monitoring onn ZeusMonitor #100

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Tests for CPU monitoring onn ZeusMonitor #100

merged 8 commits into from
Aug 15, 2024

Conversation

wbjin
Copy link
Collaborator

@wbjin wbjin commented Jul 12, 2024

Unit tests for RAPLFile, RAPLCPU, RAPLCPUs, and additions to test_monitor.py.

@wbjin wbjin requested a review from jaywonchung July 12, 2024 19:37
jaywonchung
jaywonchung reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@jaywonchung jaywonchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The tests look great.

tests/device/cpu/test_rapl.py Outdated Show resolved Hide resolved
zeus/utils/testing.py Outdated Show resolved Hide resolved
zeus/utils/testing.py Outdated Show resolved Hide resolved
zeus/utils/testing.py Outdated Show resolved Hide resolved
tests/test_monitor.py Show resolved Hide resolved
wbjin and others added 2 commits August 14, 2024 14:14
@wbjin @jaywonchung
Update tests/device/cpu/test_rapl.py
2ec49e6 
Co-authored-by: Jae-Won Chung <jwnchung@umich.edu>
@wbjin
Move MockCPU and MockCPUs
b631fab
jaywonchung
jaywonchung approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@jaywonchung jaywonchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jaywonchung jaywonchung merged commit b19fb14 into master Aug 15, 2024
3 checks passed
@jaywonchung jaywonchung deleted the cpu_rapl_tests branch August 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaywonchung jaywonchung jaywonchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbjin @jaywonchung