-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candidate for 0.0.4 #146
Merged
Merged
Changes from all commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
f9d7a0e
Added a start at a quantile implementation in the existing MR framework.
mmcdermott 7685436
Merge branch 'dev' into 51_add_quantile_aggregation
mmcdermott 9c3b497
Got the reducer to return reasonable numbers at least.
mmcdermott 2d87cae
Merged.
mmcdermott 4b3cfec
Added doctests and parametrization.
mmcdermott e721506
VERY preliminary code. Just committing so as to not lose changes. Not…
mmcdermott 10b741a
Merge branch 'dev' into 101_match_revise
mmcdermott 76ce942
Merge branch 'dev' into alt_51_raw_values
mmcdermott 209abc1
Merged.
mmcdermott d898cb4
Merge branch 'dev' into alt_51_raw_values
mmcdermott bb88c1c
Renamed to 'code_modifiers'
mmcdermott 5a39b7c
Merge branch 'dev' into 101_match_revise
mmcdermott 949867a
Merge branch 'dev' into alt_51_raw_values
mmcdermott 8e1a78d
Very preliminary implementation of match and revise
mmcdermott e260088
Started adding documentation and tests; not yet complete
mmcdermott 8750b93
Tests added for everything except bind compute function.
mmcdermott 8e418ab
Added all doctests.
mmcdermott f19ecc7
Added an integration test via the filter_measurement transform; also …
mmcdermott 39aebbc
Attempted to update test workflow, add codecov badge, and add a workf…
mmcdermott 33ebdd9
Merge pull request #123 from mmcdermott/update_CI_and_README
mmcdermott cff193b
Merge branch 'dev' into alt_51_raw_values
mmcdermott 3b7aae0
Merge branch 'dev' into 101_match_revise
mmcdermott c9c581f
Fix split_and_shard_patients when the full split definition is provided
prenc 0b924b3
External splits go after internal splits
prenc f352654
Merge branch 'refs/heads/dev' into fix-external-split
prenc 3c69775
Added mkdocs documentation starter code.
mmcdermott ebabad7
Added readthedocs file.
mmcdermott 3840385
Added docs badge.
mmcdermott 8075963
Updated tests workflow to ignore docs.
mmcdermott 1dedfad
Updated docs to move basic docs into readthedocs.
mmcdermott 9c78213
Correct mdformat issue
mmcdermott e0d9fea
linted files.
mmcdermott 39c626e
Added revision dates and authors to docs
mmcdermott 3cc758f
Merge pull request #128 from mmcdermott/77_mkdocs_readthedocs
mmcdermott cca82d4
Merge branch 'dev' into 101_match_revise
mmcdermott 3e68573
Merge branch 'dev' into alt_51_raw_values
mmcdermott 36a172d
Merge pull request #98 from mmcdermott/alt_51_raw_values
mmcdermott fa1d6f9
Merge branch 'dev' into 101_match_revise
mmcdermott 44f18b7
Add warning when split_fracs_dict not empty but performing the split …
prenc 3fb5e8b
Merge branch 'refs/heads/dev' into fix-external-split
prenc 2e1f875
Throw ValueError when external split lengths contradict n_patient_per…
prenc 2fbb293
Add .editorconfig
prenc 8839f67
Started removing unnecessary references to shards file
mmcdermott ba6b5b6
Removed usage of shards json file throughout, outside of the direct e…
mmcdermott d86fe1e
Used a hash function instead of true randomization to order the shard…
mmcdermott 86d1acd
Made it so that docs use submodule README files as the source documen…
mmcdermott 7d6c273
Merge pull request #131 from mmcdermott/add-editorconfig
prenc f318a4a
Merge branch 'refs/heads/dev' into fix-external-split
prenc 546c763
Allow resharding of external splits, move rng declaration out of the …
prenc 430a950
Merge pull request #124 from mmcdermott/fix-external-split
prenc d719ab4
Merge pull request #132 from mmcdermott/129_remove_splits_json_file_u…
mmcdermott 224a1a8
Fixed merge conflict.
mmcdermott f2d2d0e
Fixed lint errors.
mmcdermott 631819f
Merge pull request #119 from mmcdermott/101_match_revise
mmcdermott 36add00
Moved parser around.
mmcdermott 4263592
Updated mandatory types to be separate from mandatory MEDS columns
mmcdermott 8fc4f48
Fixed bug with matcher import.
mmcdermott 0fadd96
Merge pull request #133 from mmcdermott/update_parser_and_type_info
mmcdermott dd43d5a
Fixed typo
mmcdermott fd6e77f
Separated merge shards shard iterator out for ease of import.
mmcdermott dd22eeb
Starting to add integration test for eventual functionality; not yet …
mmcdermott 1b2d023
Improved compliance by removing creation of shards.json file and addi…
mmcdermott fc877e3
Merge pull request #137 from mmcdermott/136_testing_code_compliance
mmcdermott 4b2dee2
Merge branch 'dev' into 134_reshard_by_split
mmcdermott 6ec7a8f
Updated test.
mmcdermott dd9ba08
started file; very much not ready yet.
mmcdermott 4cc65b4
Improved some documentation and error handling for splitting patients.
mmcdermott ba9c3b4
Merge branch 'dev' into 134_reshard_by_split
mmcdermott d70128f
Implemented preliminary version of reshard to split.
mmcdermott 0db3a23
fixed some more minor errors; test fails for content reasons now.
mmcdermott 829cede
code was actually fine; it was a test error.
mmcdermott 5e47f0c
Merge pull request #135 from mmcdermott/134_reshard_by_split
mmcdermott e0d1ecb
Corrected a small parallelism issue in reshard.
mmcdermott ac1587e
Made reshard not error out if the new split is identical to the shard…
mmcdermott 2d1c4cf
Fixed formatting.
mmcdermott 7b02df8
Move more to locked computation.
mmcdermott b1378bc
changes in progress to improve robustness
mmcdermott 3a95794
changes in progress to improve robustness
mmcdermott d9ed79a
Made file checker wait for valid parquet files
mmcdermott d1f5953
Removed unneeded line.
mmcdermott e0c0f46
Made rwlock more robust and eliminated unused return mode.
mmcdermott 3fc909e
Made resharding use rwlock wrap
mmcdermott cda4f06
Merge pull request #143 from mmcdermott/139_fix_reshard_to_split_in_p…
mmcdermott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
root = true | ||
|
||
[*] | ||
charset = utf-8 | ||
end_of_line = lf | ||
indent_size = 4 | ||
indent_style = space | ||
insert_final_newline = true | ||
max_line_length = 110 | ||
tab_width = 4 | ||
|
||
[{*.yaml,*.yml}] | ||
indent_size = 2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
name: Publish Python 🐍 distribution 📦 to PyPI and TestPyPI | ||
|
||
on: push | ||
|
||
jobs: | ||
build: | ||
name: Build distribution 📦 | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Set up Python | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: "3.12" | ||
- name: Install pypa/build | ||
run: >- | ||
python3 -m | ||
pip install | ||
build | ||
--user | ||
- name: Build a binary wheel and a source tarball | ||
run: python3 -m build | ||
- name: Store the distribution packages | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: python-package-distributions | ||
path: dist/ | ||
|
||
publish-to-pypi: | ||
name: >- | ||
Publish Python 🐍 distribution 📦 to PyPI | ||
if: startsWith(github.ref, 'refs/tags/') # only publish to PyPI on tag pushes | ||
needs: | ||
- build | ||
runs-on: ubuntu-latest | ||
environment: | ||
name: pypi | ||
url: https://pypi.org/p/MEDS-transforms # Replace <package-name> with your PyPI project name | ||
permissions: | ||
id-token: write # IMPORTANT: mandatory for trusted publishing | ||
|
||
steps: | ||
- name: Download all the dists | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: python-package-distributions | ||
path: dist/ | ||
|
||
- name: Publish distribution 📦 to PyPI | ||
uses: pypa/gh-action-pypi-publish@release/v1 | ||
|
||
github-release: | ||
name: >- | ||
Sign the Python 🐍 distribution 📦 with Sigstore | ||
and upload them to GitHub Release | ||
needs: | ||
- publish-to-pypi | ||
runs-on: ubuntu-latest | ||
|
||
permissions: | ||
contents: write # IMPORTANT: mandatory for making GitHub Releases | ||
id-token: write # IMPORTANT: mandatory for sigstore | ||
|
||
steps: | ||
- name: Download all the dists | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: python-package-distributions | ||
path: dist/ | ||
|
||
- name: Sign the dists with Sigstore | ||
uses: sigstore/gh-action-sigstore-python@v2.1.1 | ||
with: | ||
inputs: >- | ||
./dist/*.tar.gz | ||
./dist/*.whl | ||
- name: Create GitHub Release | ||
env: | ||
GITHUB_TOKEN: ${{ github.token }} | ||
run: >- | ||
gh release create | ||
'${{ github.ref_name }}' | ||
--repo '${{ github.repository }}' | ||
--notes "" | ||
- name: Upload artifact signatures to GitHub Release | ||
env: | ||
GITHUB_TOKEN: ${{ github.token }} | ||
# Upload to GitHub Release using the `gh` CLI. | ||
# `dist/` contains the built packages, and the | ||
# sigstore-produced signatures and certificates. | ||
run: >- | ||
gh release upload | ||
'${{ github.ref_name }}' dist/** | ||
--repo '${{ github.repository }}' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Read the Docs configuration file | ||
# See https://docs.readthedocs.io/en/stable/config-file/v2.html for details | ||
|
||
# Required | ||
version: 2 | ||
|
||
# Set the version of Python and other tools you might need | ||
build: | ||
os: ubuntu-22.04 | ||
tools: | ||
python: "3.12" | ||
|
||
python: | ||
install: | ||
- method: pip | ||
path: . | ||
extra_requirements: | ||
- docs | ||
|
||
mkdocs: | ||
configuration: mkdocs.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trigger on specific branches or tags.
Currently, the workflow triggers on all pushes. Consider specifying branches or tags to avoid unnecessary builds.