Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reorder_measurements transformation. #48

Merged
merged 11 commits into from
Aug 3, 2024

Conversation

mmcdermott
Copy link
Owner

@mmcdermott mmcdermott commented Jul 19, 2024

This allows you to specify a list of regexs in a config variable and measurements will be sorted, within a patient-id X timestamp level, by the earliest index of the regex they satisfy. This would close #47

Still needed:

Copy link
Contributor

coderabbitai bot commented Jul 19, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mmcdermott mmcdermott marked this pull request as ready for review August 2, 2024 14:19
@mmcdermott mmcdermott requested a review from prenc August 2, 2024 14:19
@mmcdermott
Copy link
Owner Author

@prenc I think this should work for your use cases? You can see it in use in the doctests and/or test case added here. Let me know if this is missing any functionality you'd want for this transform, and otherwise we can push it.

@mmcdermott mmcdermott changed the title Added starter code for reordering by code patterns Added reorder_measurements transformation. Aug 2, 2024
@mmcdermott
Copy link
Owner Author

This should wait for #107 to go in as it will allow us to simplify the interface on this new transformation slightly.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.50%. Comparing base (07140c1) to head (39b8fc2).
Report is 107 commits behind head on dev.

Files Patch % Lines
...MEDS_transforms/transforms/reorder_measurements.py 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #48      +/-   ##
==========================================
+ Coverage   84.85%   92.50%   +7.65%     
==========================================
  Files          17       24       +7     
  Lines        1096     1628     +532     
==========================================
+ Hits          930     1506     +576     
+ Misses        166      122      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmcdermott mmcdermott merged commit da951be into dev Aug 3, 2024
2 checks passed
@mmcdermott mmcdermott deleted the 47_transformation_for_reordering_measurements branch August 3, 2024 17:07
@mmcdermott
Copy link
Owner Author

@prenc I actually merged this by accident, but I think it should work for your use case and don't want to revert it. Please let me know if you see any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants