-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reorder_measurements
transformation.
#48
Added reorder_measurements
transformation.
#48
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
… docstrings and integration tests.
…tests and docstrings.
@prenc I think this should work for your use cases? You can see it in use in the doctests and/or test case added here. Let me know if this is missing any functionality you'd want for this transform, and otherwise we can push it. |
reorder_measurements
transformation.
This should wait for #107 to go in as it will allow us to simplify the interface on this new transformation slightly. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #48 +/- ##
==========================================
+ Coverage 84.85% 92.50% +7.65%
==========================================
Files 17 24 +7
Lines 1096 1628 +532
==========================================
+ Hits 930 1506 +576
+ Misses 166 122 -44 ☔ View full report in Codecov by Sentry. |
@prenc I actually merged this by accident, but I think it should work for your use case and don't want to revert it. Please let me know if you see any issues. |
This allows you to specify a list of regexs in a config variable and measurements will be sorted, within a patient-id X timestamp level, by the earliest index of the regex they satisfy. This would close #47
Still needed: