Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author icons does not adapt to dark minimal_mistakes_skin. #1482

Closed
3 of 5 tasks
kwlin opened this issue Jan 16, 2018 · 3 comments
Closed
3 of 5 tasks

Author icons does not adapt to dark minimal_mistakes_skin. #1482

kwlin opened this issue Jan 16, 2018 · 3 comments

Comments

@kwlin
Copy link

kwlin commented Jan 16, 2018

  • This is a question about using the theme.
  • This is a feature request.
  • I believe this to be a bug with the theme.
    • I have updated all gems with bundle update.
    • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: 4.9.0
  • Jekyll version: 3.7.0
  • GitHub Pages hosted: yes
  • Operating system: Windows 10 (using Bash on Linux)

Expected behavior

I have applied the dark skin on my _config.yml and It seems that the icons of the author url's aren't adapted/changed by the dark skin as documention. My expectations was that the twitter, linkedin & github icons are grey icons instead of blue or black icons.

My Jekyll site (local screenshot):
image

Expected example:
image

I've verified that the include @import "minimal-mistakes/skins/default"; // skin is defined in the main.scss and on the right place.

Am I missing something in my configuration?

Steps to reproduce the behavior

@Sciss
Copy link

Sciss commented Jan 16, 2018

@mmistakes
Copy link
Owner

@kwlin Good catch. The fix until I get to it is adding this:

.social-icons .svg-inline--fa {
  color: inherit !important;
}

@kwlin
Copy link
Author

kwlin commented Jan 17, 2018

@mmistakes Thanks for the fix. I'll see it in the new version of gem :)

kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
sumeetmondal pushed a commit to sumeetmondal/sumeetmondal.github.io that referenced this issue Sep 10, 2019
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants