Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yandex and Alexa verifications require missing configuration flags #347

Closed
3 of 5 tasks
ghost opened this issue Jun 9, 2016 · 1 comment
Closed
3 of 5 tasks

Yandex and Alexa verifications require missing configuration flags #347

ghost opened this issue Jun 9, 2016 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 9, 2016

  • This is a question about using the theme.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: 3.2.1
  • github-pages or jekyll gem version: 3.1.6
  • Operating system: OS X 10.11.5

Expected behavior

Adding a value to site.alexa_site_verification or site.yandex_site_verification front matter does not output the expected meta tags given seo.html has liquid conditions requiring a flag under site.owner.[service].verify to be truthy in order to output the tag.

Steps to reproduce the behavior

  1. Add a verification codes for Alexa or Yandex to _config.yml.
  2. Observe no new meta tags output in the generated document head.

Here's the webmaster verification related code in seo.html as of this version:

{% if site.google_site_verification %}
  <meta name="google-site-verification" content="{{ site.google_site_verification }}" />
{% endif %}
{% if site.bing_site_verification %}
  <meta name="msvalidate.01" content="{{ site.bing_site_verification }}">
{% endif %}
{% if site.owner.alexa.verify %}
  <meta name="alexaVerifyID" content="{{ site.alexa_site_verification }}">
{% endif %}
{% if site.owner.yandex.verify %}
  <meta name="yandex-verification" content="{{ site.yandex_site_verification }}">
{% endif %}

Is there a specific reason Yandex and Alexa don't follow the same branch logic pattern used for Google or Bing?

@mmistakes
Copy link
Owner

mmistakes commented Jun 9, 2016

@jhabdas Looks like you found some typos. Both Alexa and Yandex should follow the same logic as the others. owner shouldn't be in the variable names.

Happy to merge in a pull request if you want to take a stab at fixing it. Should be a super easy change.

sobkowiak pushed a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Jul 18, 2016
sobkowiak pushed a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Jul 18, 2016
cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this issue Dec 7, 2016
jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant