Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish locale #1304

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Polish locale #1304

merged 1 commit into from
Oct 16, 2017

Conversation

kbl
Copy link
Contributor

@kbl kbl commented Oct 14, 2017

Adding polish locale to ui-text.yml

@mmistakes
Copy link
Owner

Thanks for the PR!

@mmistakes mmistakes merged commit 52f2451 into mmistakes:master Oct 16, 2017
mmistakes added a commit that referenced this pull request Oct 16, 2017
@kbl
Copy link
Contributor Author

kbl commented Oct 16, 2017

NP, I should rather say - thank you for the theme ;)

Unfortunately my translation isn't "perfect". In Polish there is a difference between "next" used with pages and posts. The same is true for reading time, depending on number "minutes" could have 3 different forms (https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/pl.yml#L106) ;)

I don't know what is your intention there. Would you like rather to keep it simple/concise or support all language quirks.

@mmistakes
Copy link
Owner

Simple and concise is fine. Since the data file is editable my intention is just to provide a starting point and if someone wants to tailor the text to suit their needs they can.

kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this pull request May 30, 2019
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this pull request May 30, 2019
sumeetmondal pushed a commit to sumeetmondal/sumeetmondal.github.io that referenced this pull request Sep 10, 2019
sumeetmondal pushed a commit to sumeetmondal/sumeetmondal.github.io that referenced this pull request Sep 10, 2019
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this pull request May 5, 2023
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants