Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color notices based on skin colors instead of fixed values #2887

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Color notices based on skin colors instead of fixed values #2887

merged 4 commits into from
Apr 13, 2021

Commits on Mar 25, 2021

  1. Made notice Sass color mixing in based on $background-color and $text… 

    …-color instead of hard-coded black and white values.
    Tom Manner committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    91701b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Made some style adjustments to notices to improve readability. 

    Notice links are slightly darkened from the notice color, mostly because the gray-on-gray default notice links were very hard to read.  Rather than being $notice-color, they are `mix(#000, $notice-color, 10%)`.
The notice background mix and code-background mix can now be set with the SCSS variables $notice-background-mix and $code-notice-background-mix.
The default mix for background was adjusted to 80%, from 90%.
The default mix for code-background was adjusted to 90%, from 95%.
Skins that still didn't read well were adjusted individually.
    @tsmanner
    tsmanner committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    08ace24 View commit details
    Browse the repository at this point in the history

  2. Adjusted sunrise $notice-background-mix to 75%

    @tsmanner
    tsmanner committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    59aa6e7 View commit details
    Browse the repository at this point in the history

  3. Adjusted dark theme notice background mix colors back to the default

    @tsmanner
    tsmanner committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    73f5442 View commit details
    Browse the repository at this point in the history