-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: window and layout in GUI API #10646
Conversation
Sounds reasonable, let me know when to look! |
This is delayed until #10565 (comment) is resolved. |
Okay, let me know what PR to review whenever one of them is ready |
Assuming the CIs return green, this is ready for review @larsoner |
The failure on
|
That looks like a replication of #10648 on CIs, the first time I've seen it! Agreed it's unrelated, though |
Thanks @GuillaumeFavelier ! |
This PR refactors
_QtWindow
:_window_create
to spawn a window 'without pyvista support' (instance of_MNEMainWindow
)adds the optiontheme_support
to opt-out from automatic themingand
_QtLayout
:Here is a code snippet to try:
Further consideration:
_get_renderer()
to spawn_MNEMainWindow
instead of using_PyVistaRenderer
. This more important matter is about about having a GUI API which does not depends onpyvista
.It's an item of #10565