Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Add dependencies for widget abstraction #10935

Closed
wants to merge 2 commits into from

Conversation

alexrockhill
Copy link
Contributor

Fixes parts of #10913.

@alexrockhill
Copy link
Contributor Author

Ah okay so does look like the dependencies are the issue, odd! I'll see if I can figure out how to fix it.

@larsoner
Copy link
Member

It's possible then that this is a test that used to be skipped on Windows (because of missing deps) but isn't. In that case I think it's okay to @pytest.mark.skipif based on the sys.platform with a # TODO: comment saying we should fix it at some point.

But if you want to continue and try to fix it, that's even better @alexrockhill -- up to you!

@alexrockhill
Copy link
Contributor Author

alexrockhill commented Jul 19, 2022

It's possible then that this is a test that used to be skipped on Windows (because of missing deps) but isn't. In that case I think it's okay to @pytest.mark.skipif based on the sys.platform with a # TODO: comment saying we should fix it at some point.

But if you want to continue and try to fix it, that's even better @alexrockhill -- up to you!

It took me several hours (a bit embarrassingly because of my lack of Windows ability but also I did have to go into the CIs and use the install OpenGL script to get the 3D plots to work which isn't too basic) to get the test up on Windows so since I already sunk that time in and I have a machine that I have access to with things working, I'd really like to loop around at the end of GSoC and make sure everything works and looks nice on Windows. I remember with the ieeg_locate GUI, there were some really terrible things on Windows (the side bar with the channel names looked totally off as I recall) so I think that is really important to get done but I also want to make sure to stay on track so I'd like to do that as one big bug squashing PR at the end.

@alexrockhill alexrockhill deleted the backend2 branch July 19, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants