Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling in warning on cHPI #12095

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Fix spelling in warning on cHPI #12095

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fd1cdbf
fix spelling
mscheltienne Oct 10, 2023
5ceb7af
FIX: Fix writing
larsoner Oct 10, 2023
4491737
TST: Ping [circle front]
larsoner Oct 10, 2023
fff5bbc
FIX: Endian [circle front]
larsoner Oct 10, 2023
affacf5
FIX: Import [circle front]
larsoner Oct 10, 2023
cb173b8
FIX: Import [circle front]
larsoner Oct 10, 2023
8bb98e8
FIX: Revert [circle front]
larsoner Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mne/_fiff/write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,8 @@ def write_string(fid, kind, data):
except UnicodeEncodeError:
str_data = str(data).encode("latin1", errors="xmlcharrefreplace")
data_size = len(str_data) # therefore compute size here
my_dtype = ">a" # py2/3 compatible on writing -- don't ask me why
if data_size > 0:
_write(fid, str_data, kind, data_size, FIFF.FIFFT_STRING, my_dtype)
_write(fid, str_data, kind, data_size, FIFF.FIFFT_STRING, "S")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscheltienne I'm hijacking your PR to sneak in some CI fixes, hope you don't mind :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing unusual :)



def write_name_list(fid, kind, data):
Expand Down
4 changes: 2 additions & 2 deletions mne/chpi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,8 +629,8 @@ def _setup_hpi_amplitude_fitting(
for key in ("sss_info", "max_st"):
if len(ent["max_info"]["sss_info"]) > 0:
warn(
"Fitting cHPI amplutudes after Maxwell filtering may not to work, "
"consider fitting on the original data"
"Fitting cHPI amplitudes after Maxwell filtering may not work, "
"consider fitting on the original data."
)
break

Expand Down
Loading