Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Add support for smoothing_steps=0 #7191

Merged

Conversation

GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Jan 10, 2020

This PR adds support for 'nearest' interpolation when the number of smoothing_steps=0.

Example with plot_visualize_stc.py:

smoothing_steps=0 smoothing_steps=1 smoothing_steps=10
2020-01-10_1920x1080 2020-01-10_1920x1080 2020-01-10_1920x1080

It's an item of #7162

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #7191 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7191      +/-   ##
==========================================
+ Coverage   89.75%   89.76%   +<.01%     
==========================================
  Files         445      445              
  Lines       79726    79740      +14     
  Branches    12754    12755       +1     
==========================================
+ Hits        71562    71576      +14     
  Misses       5370     5370              
  Partials     2794     2794

@GuillaumeFavelier GuillaumeFavelier changed the title WIP: Add support for smoothing_steps=0 MRG: Add support for smoothing_steps=0 Jan 10, 2020
@GuillaumeFavelier
Copy link
Contributor Author

What do you think @agramfort, @larsoner ?

@agramfort agramfort merged commit 9a21433 into mne-tools:master Jan 11, 2020
@agramfort
Copy link
Member

works like a charm @GuillaumeFavelier ! thx

AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the brain_nearest_smoothing branch June 11, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants