Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orientation slider when hemi=both #7383

Conversation

GuillaumeFavelier
Copy link
Contributor

This PR fixes the overlap of the sliders when hemi=both.

It's an item of #7162

@agramfort
Copy link
Member

can you share a test script to check/replicate?

@GuillaumeFavelier
Copy link
Contributor Author

Running the following:

import os
import mne
from mne.datasets import sample
data_path = sample.data_path()
sample_dir = os.path.join(data_path, 'MEG', 'sample')
subjects_dir = os.path.join(data_path, 'subjects')
fname_stc = os.path.join(sample_dir, 'sample_audvis-meg')
stc = mne.read_source_estimate(fname_stc, subject='sample')
with mne.viz.use_3d_backend('pyvista'):
    brain = stc.plot(subjects_dir=subjects_dir,
                     clim=dict(kind='value', pos_lims=[3, 6, 9]),
                     time_viewer=True, hemi='both')

This is what I get:

master PR
2020-03-04_1920x1080 2020-03-04_1920x1080

@larsoner larsoner added this to the 0.20 milestone Mar 4, 2020
@larsoner larsoner merged commit 3f9ef1c into mne-tools:master Mar 4, 2020
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Mar 5, 2020
86 tasks
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the time_viewer_overlap_orientation_slider branch June 11, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants